Skip to content

fix: mark @types/conventional-commits-parser as dep for @commitlint/types#3944

Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom
JounQin:fix/types
Feb 28, 2024
Merged

fix: mark @types/conventional-commits-parser as dep for @commitlint/types#3944
escapedcat merged 1 commit intoconventional-changelog:masterfrom
JounQin:fix/types

Conversation

@JounQin
Copy link
Copy Markdown
Collaborator

@JounQin JounQin commented Feb 28, 2024

Description

close #3929, fix #3942

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat escapedcat merged commit 5a01f59 into conventional-changelog:master Feb 28, 2024
@JounQin JounQin deleted the fix/types branch February 28, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

fix: error TS2307: Cannot find module 'conventional-commits-parser' or its corresponding type declarations.

2 participants