Skip to content

fix: remove build on any branches except main and tags#3674

Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom
shanduur:patch-1
Oct 3, 2023
Merged

fix: remove build on any branches except main and tags#3674
escapedcat merged 1 commit intoconventional-changelog:masterfrom
shanduur:patch-1

Conversation

@shanduur
Copy link
Copy Markdown
Contributor

@shanduur shanduur commented Oct 3, 2023

Description

Build and push only releases and master branch (via cron).

Motivation and Context

Right now every branch that is created in the repo triggers build in the repository. This includes branches created by Renovate. We don't want it - only master (via cron) and releases should be built

Usage examples

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shanduur
fix: remove build on any branches except main and tags
b75f864 
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
@shanduur shanduur mentioned this pull request Oct 3, 2023
Merged
13 tasks
AdeAttwood
AdeAttwood requested changes Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@AdeAttwood AdeAttwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this on the master branch for the edge tag. Its only feature, branches we don't want.

@shanduur
Copy link
Copy Markdown
Contributor Author

shanduur commented Oct 3, 2023

@AdeAttwood but previously you had '!master' - meaning exclude master from builds.

@shanduur
Copy link
Copy Markdown
Contributor Author

shanduur commented Oct 3, 2023 •
edited
Loading

Cron job is started on default branch (in this case master) and it will be tagged as edge - no need to explicitly mention it in the workflow.

@shanduur shanduur requested a review from AdeAttwood October 3, 2023 11:07
@escapedcat
Copy link
Copy Markdown
Member

escapedcat commented Oct 3, 2023

@kaiehrhardt wdyt?

@AdeAttwood
Copy link
Copy Markdown
Member

AdeAttwood commented Oct 3, 2023

@escapedcat good to go when you are.

@escapedcat
Copy link
Copy Markdown
Member

escapedcat commented Oct 3, 2023

Thanks @shanduur !

@escapedcat escapedcat merged commit cfc647f into conventional-changelog:master Oct 3, 2023
@shanduur shanduur deleted the patch-1 branch October 3, 2023 12:31
@commit-lint commit-lint bot mentioned this pull request Oct 3, 2023
Merged
@kaiehrhardt
Copy link
Copy Markdown
Contributor

kaiehrhardt commented Oct 4, 2023

sorry for the late response. no ci tests for the docker image build? :'(
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request could be an option, i think.

@escapedcat
Copy link
Copy Markdown
Member

escapedcat commented Oct 5, 2023

sorry for the late response.

No worries, happy with any time you want to spend here.

no ci tests for the docker image build? :'( https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request could be an option, i think.

Anyone up for a PR? :P

@kaiehrhardt kaiehrhardt mentioned this pull request Oct 5, 2023
Merged
@ViPeR5000 ViPeR5000 mentioned this pull request Jun 15, 2024
Open
@Loonz206 Loonz206 mentioned this pull request Aug 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdeAttwood AdeAttwood AdeAttwood approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shanduur @escapedcat @AdeAttwood @kaiehrhardt