Fix recognizing “tag not found” in oci:, and add that for oci-archive:#2613
Fix recognizing “tag not found” in oci:, and add that for oci-archive:#2613mtrmac merged 3 commits intocontainers:mainfrom
oci:, and add that for oci-archive:#2613Conversation
oci:, and add that for oci-archive:
Thanks for fixing that. Out of curiosity how did you find this? |
|
BTW it looks like I lost my "official reviewer" status on this repo, do you want to readd it? |
I added
That might have happened while formalizing the rules (for CNCF, around #2570) due to a disconnect between GitHub permissions and text records… and now there’s a bit of a process involved. I’ll ask around. |
124b952 to
1166a33
Compare
a584d98 to
bc3c2c8
Compare
|
@mtrmac do we need any systemtest updates here? |
|
@lsm5 Specifically system tests? This is upstream-motivated, not tracked in a downstream product, so I don’t think there’s a reason to have a system test and not an integration tests (but there could well be something I’m missing). Arguably the |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
No tests because we aren't testing oci-archive: anywhere else either. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
bc3c2c8 to
99c6fb0
Compare
It turns out the
oci:“tag not found” handling in #1757 never worked (it used a value equality check instead of a type conformance check). Fix that, and add a unit test.Also, implement the same semantics for
oci-archive:, per #2114. Only manually tested.Unlike #2114, this does not add “exit status 2” for “the whole archive is missing”. I don’t think that needs special handling, and it seems no caller currently cares.