Skip to content

hack: Support picking cc and cpp via environment variables.#2322

Merged
mtrmac merged 1 commit intocontainers:mainfrom
graywolf:master
May 9, 2024
Merged

hack: Support picking cc and cpp via environment variables.#2322
mtrmac merged 1 commit intocontainers:mainfrom
graywolf:master

Conversation

@graywolf
Copy link
Copy Markdown
Contributor

@graywolf graywolf commented May 8, 2024

Until now `cc' was hard-coded as the only compiler used. Supporting selecting the compiler and preprocessor to be used via environment variables makes life easier for distributors, so this commit mimics how podman does it in its hack/* scripts.

Fixes #2278.

Until now `cc' was hard-coded as the only compiler used.  Supporting selecting
the compiler and preprocessor to be used via environment variables makes life
easier for distributors, so this commit mimics how podman does it in its hack/*
scripts.

Signed-off-by: Tomas Volf <~@wolfsden.cz>
@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Copy Markdown
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @graywolf

Ephemeral COPR build failed. @containers/packit-build please check.

ignore unrelated rpm-build:centos-stream failures.

LGTM looking at the same files in podman. FWIW, hack/libsubid_tag.sh in podman doesn't have the change yet.

@mtrmac PTAL.

Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac mtrmac merged commit 2ac5bea into containers:main May 9, 2024
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The checks in hack/ directory hardcode `cc'

3 participants