Add a new Signer API for creating simple signing signatures with Sequoia-PGP#2896
Merged
mtrmac merged 1 commit intocontainers:mainfrom Jul 11, 2025
Merged
Add a new Signer API for creating simple signing signatures with Sequoia-PGP#2896mtrmac merged 1 commit intocontainers:mainfrom
mtrmac merged 1 commit intocontainers:mainfrom
Conversation
…oia-PGP This API is proven end-to-end in containers#2876 and containers/skopeo#2645 , but it is not yet convenient to use becahse the Rust dependency has to be compiled manually. So, for now, add the API as a stub only; that allows building the CLIs and tests on top, and they will light up once the backend is added. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
commented
Jul 10, 2025
| func WithPassphrase(passphrase string) Option { | ||
| return func(s *simpleSequoiaSigner) error { | ||
| // The gpgme implementation can’t use passphrase with \n; reject it here for consistent behavior. | ||
| // FIXME: We don’t need it in this API at all, but the "\n" check exists in the current call stack. That should go away. |
Collaborator
Author
There was a problem hiding this comment.
POC of this is my branch sequoia-refactor-SignDockerManifest, but that can wait.
Luap99
approved these changes
Jul 11, 2025
Member
Luap99
left a comment
There was a problem hiding this comment.
LGTM, seems reasonable to have the stub API merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API is proven end-to-end in #2876 and containers/skopeo#2645 , but it is not yet convenient to use becahse the Rust dependency has to be compiled manually.
So, for now, add the API as a stub only; that allows building the CLIs and tests on top, and they will light up once the backend is added.
Cc: @Luap99 (@ueno ). I think the linked PRs show that the API is viable, and something we can commit to right now; adding a do-nothing stub might help with the CI inclusion / packaging ordering, as discussed, earlier.g. in containers/skopeo#2645 (comment) .