Fix parsing of cgroupv2 cpu.stat#431
Merged
Merged
Conversation
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 31, 2025
|
✅ A new PR has been created in buildah to vendor these changes: podman-container-tools/buildah#6466 |
lsm5
approved these changes
Nov 3, 2025
lsm5
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks!
LGTM (not a maintainer).
Unit-conver the value we read, not the other one. In theory, this should not make a difference because both values are expected to be always present. (Found by Cursor during unrelated cleanups.) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit-conver the value we read, not the other one.
In theory, this should not make a difference because both values are expected to be always present.
(Found by Cursor during unrelated cleanups.)
@giuseppe @lsm5 PTAL