opendownstream-pr.yml: render breaklines correctly#400
Merged
Conversation
Contributor
Author
|
@Luap99 PTAL |
Luap99
reviewed
Oct 17, 2025
| BRANCH_NAME="sync/container-libs-${{ github.event.pull_request.number }}" | ||
| PR_TITLE="Sync: ${SELF_REPO_PR_TITLE}" | ||
| PR_BODY="This PR automatically vendors changes from [container-libs#${SELF_REPO_PR_NUMBER}](${SELF_REPO_PR_URL}).\n This PR is intended solely for testing purposes and should not be merged. Ideally, upstream maintainers should review any failing tests here and close this PR once the upstream PR is merged. Maintainers of this repository do not need to take any action, but may review the changes and notify upstream maintainers of any breaking issues if they wish. \n\nThis PR is generated from a github actions workflow, please report any issues on https://github.com/containers/container-libs" | ||
| PR_BODY="This PR automatically vendors changes from [container-libs#${SELF_REPO_PR_NUMBER}](${SELF_REPO_PR_URL}).<br> This PR is intended solely for testing purposes and should not be merged. Ideally, upstream maintainers should review any failing tests here and close this PR once the upstream PR is merged. Maintainers of this repository do not need to take any action, but may review the changes and notify upstream maintainers of any breaking issues if they wish. <br><br>This PR is generated from a github actions workflow, please report any issues on https://github.com/containers/container-libs" |
Member
There was a problem hiding this comment.
The github PR descriptions are markdown not html. Yes <br> are generally render correctly in markdown so this likely works but isn't the proper thing to just split the text in its paragraphs which then also makes it much more readable here in the source.
You should be able to have a multi line string just fine in bash here
dc815c5 to
11c3a14
Compare
Contributor
Author
|
@Luap99 PTAL |
Luap99
reviewed
Oct 17, 2025
Comment on lines
+110
to
+112
| This PR is intended solely for testing purposes and should not be merged. Ideally, upstream maintainers should review any failing tests here and close this PR once the upstream PR is merged. Maintainers of this repository do not need to take any action, but may review the changes and notify upstream maintainers of any breaking issues if they wish. | ||
|
|
||
| This PR is generated from a github actions workflow, please report any issues on https://github.com/containers/container-libs" |
Member
There was a problem hiding this comment.
that does not look like a valid yaml file, you must maintain the yaml indentation
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
11c3a14 to
8f4bc1d
Compare
mtrmac
approved these changes
Oct 20, 2025
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
Reading https://yaml.org/spec/1.2.2/#731-double-quoted-style , we might need one more empty line between paragraphs (newlines in non-empty lines are discarded) but let’s try this one first.
Contributor
I was wrong, podman-container-tools/buildah#6445 (comment) looks perfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix rendering breaklines in github PR description.