common: add libartifact#392
Merged
Merged
Conversation
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 15, 2025
|
✅ A new PR has been created in buildah to vendor these changes: podman-container-tools/buildah#6430 |
Contributor
|
LGTM |
Luap99
reviewed
Oct 16, 2025
Luap99
left a comment
Member
There was a problem hiding this comment.
to minor comments, I guess this ties into the discussion we were having about the formatter: podman-container-tools/podman#27291
|
|
||
| // if the storage dir does not exist, we need to create it. | ||
| baseDir := filepath.Dir(artifactStore.indexPath()) | ||
| if err := os.MkdirAll(baseDir, 0700); err != nil { //nolint:gofumpt |
Member
There was a problem hiding this comment.
shouldn't this just be written as 0o700 instead of silencing the linter?
| if err := fileutils.Exists(path); err == nil { | ||
| return nil | ||
| } | ||
| return os.WriteFile(path, specV1.DescriptorEmptyJSON.Data, 0644) //nolint:gofumpt |
this pr lands libartifact in common/pkg/libartifact. the code comes from podman unchanged with the exception of changing import paths and the definition of an ArtifactBlob being added. I also had to change a bunch of things because the linters are more strict here. https://issues.redhat.com/browse/RUN-3618 Signed-off-by: Brent Baude <bbaude@redhat.com>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 16, 2025
This was referenced Oct 16, 2025
rhatdan
pushed a commit
to rhatdan/container-libs
that referenced
this pull request
Nov 21, 2025
common: add libartifact Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr lands libartifact in common/pkg/libartifact. the code comes from podman unchanged with the exception of changing import paths and the definition of an ArtifactBlob being added.
https://issues.redhat.com/browse/RUN-3618