Only generate a Go file if the file has some services#112
Merged
mxpv merged 1 commit intocontainerd:mainfrom Apr 20, 2022
Merged
Only generate a Go file if the file has some services#112mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
Otherwise, this generator creates a Go file with some import statements, that causes "imported and not used" error. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 63.87% 61.89% -1.98%
==========================================
Files 11 12 +1
Lines 1049 1299 +250
==========================================
+ Hits 670 804 +134
- Misses 334 427 +93
- Partials 45 68 +23
Continue to review full report at Codecov.
|
dmcgowan
approved these changes
Apr 19, 2022
mxpv
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, this generator creates a Go file with some import statements,
that causes "imported and not used" error.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com