Add Makefile and update protobuf#106
Merged
estesp merged 3 commits intocontainerd:mainfrom Mar 7, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 63.87% 63.67% -0.20%
==========================================
Files 11 11
Lines 1049 1049
==========================================
- Hits 670 668 -2
- Misses 334 336 +2
Partials 45 45
Continue to review full report at Codecov.
|
a4f5d8d to
7cf1e14
Compare
Member
Author
|
Marked this as ready for review. There was originally a failure on Windows showing a closed that was not caught. It stopped showing up but I added more logging so we can see the type of error to check in the future. |
Use makefile and installation script for protoc. Update protoc version to match containerd. Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
7cf1e14 to
f8e8cc4
Compare
AkihiroSuda
approved these changes
Mar 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates protobuf version to v3.11.4 to match with containerd.
Adds a Makefile for the workflow and updates ci to use Makefile.