Wrap correct error on unix.GetsockoptUcred failure#100
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Jan 21, 2022
tklauser:ucred-wrap-err
Merged
Wrap correct error on unix.GetsockoptUcred failure#100dmcgowan merged 1 commit intocontainerd:mainfrom tklauser:ucred-wrap-err
dmcgowan merged 1 commit intocontainerd:mainfrom
tklauser:ucred-wrap-err
Conversation
Wrap ucredErr which is set by unix.GetsockoptUcred, not the nil err. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 72.52% 74.03% +1.51%
==========================================
Files 11 11
Lines 728 728
==========================================
+ Hits 528 539 +11
+ Misses 158 148 -10
+ Partials 42 41 -1
Continue to review full report at Codecov.
|
kzys
approved these changes
Jan 21, 2022
dmcgowan
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap ucredErr which is set by unix.GetsockoptUcred, not the nil err.