Update GitHub actions CI workflow#124
Merged
estesp merged 1 commit intocontainerd:mainfrom Mar 9, 2023
Merged
Conversation
Member
|
This seems to be consistently failing even after 2 re-runs: only on Windows platform. Not sure what's up there |
Member
Author
I'm looking into this more. It looks like a flaky test on Windows as it is now failing in mainline. |
8caeecb to
86d0a4c
Compare
f7b1c88 to
81130e7
Compare
Member
Author
Member
|
Rebase now and this should be mergable |
Closed
swagatbora90
approved these changes
Mar 8, 2023
81130e7 to
7e1dc73
Compare
Update GitHub Actions runner OS from Ubuntu 18.04 to Ubuntu 22.04. Update actions/setup-go from v2 to v3. Update Go compiler from Go 1.17 to Go 1.20. Update golangci-lint from v1.45.0 to v1.51.2 for Go 1.20 support. Remove deprecated `-i` flag from make coverage target. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
7e1dc73 to
c7b5a32
Compare
Member
Author
Rebased. Will continue to troubleshoot Windows CI flakiness further but this should in a good enough state to keep the lights on for CI / unblock the telemetry work by @swagatbora90 . |
estesp
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update GitHub actions runner OS from Ubuntu 18.04 to Ubuntu 22.04.
Update Go compiler from Go 1.17 to Go 1.20. Update actions/setup-go from
v2 to v3. Update golangci-lint to v1.51.x for Go 1.20 support. Remove
deprecated
-iflag from make coverage target.Related issue: containerd/project#95
Signed-off-by: Austin Vazquez macedonv@amazon.com