Skip to content

[release/1.7] Handle pod transition states gracefully while listing pod stats#9905

Merged
estesp merged 2 commits intocontainerd:release/1.7from
dims:cherry-pick-jsturtevant-fix-windows-edge-cases
Mar 1, 2024
Merged

[release/1.7] Handle pod transition states gracefully while listing pod stats#9905
estesp merged 2 commits intocontainerd:release/1.7from
dims:cherry-pick-jsturtevant-fix-windows-edge-cases

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Mar 1, 2024

original PR text from #8671

When the pods are transitioning there are several cases where containers might not be in valid state. There were several 
cases where the stats where failing hard but we should just continue on as they are transient  and will be picked up again 
when kubelet queries for the stats again.

I've found these after running the e2e tests in https://github.com/kubernetes/kubernetes/pull/116968 several times.

When the pods are transitioning there are several
cases where containers might not be in valid state.
There were several cases where the stats where
failing hard but we should just continue on as
they are transient and will be picked up again
when kubelet queries for the stats again.

Signed-off-by: James Sturtevant <jstur@microsoft.com>

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@dims dims assigned dims, fuweid and AkihiroSuda and unassigned dims Mar 1, 2024
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@estesp estesp merged commit 80a8047 into containerd:release/1.7 Mar 1, 2024
@dmcgowan dmcgowan added area/cri Container Runtime Interface (CRI) impact/changelog labels Mar 7, 2024
@dmcgowan dmcgowan changed the title [release/1.7][cri] Handle pod transition states gracefully while listing pod stats [release/1.7] Handle pod transition states gracefully while listing pod stats Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) impact/changelog size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants