Skip to content

[release/1.7] CDI: Use CRI Config.CDIDevices field for CDI injection#8519

Merged
fuweid merged 1 commit intocontainerd:release/1.7from
bart0sh:PR008-CDI-use-CRI-field-1.7
May 17, 2023
Merged

[release/1.7] CDI: Use CRI Config.CDIDevices field for CDI injection#8519
fuweid merged 1 commit intocontainerd:release/1.7from
bart0sh:PR008-CDI-use-CRI-field-1.7

Conversation

@bart0sh
Copy link
Copy Markdown
Contributor

@bart0sh bart0sh commented May 16, 2023 •
edited
Loading

This is a cherry-pick of the recent CDI enhancement to 1.7

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 16, 2023

Hi @bart0sh. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh
Copy link
Copy Markdown
Contributor Author

bart0sh commented May 16, 2023

/assign @fuweid @mikebrow @AkihiroSuda

@fuweid fuweid changed the title Cherry-pick: Get CDI devices from CRI Config.CDIDevices field [release/1.7] Get CDI devices from CRI Config.CDIDevices field May 16, 2023
@fuweid fuweid changed the title [release/1.7] Get CDI devices from CRI Config.CDIDevices field [release/1.7] CDI: Use CRI Config.CDIDevices field for CDI injection May 16, 2023
@fuweid
Copy link
Copy Markdown
Member

fuweid commented May 16, 2023

@bart0sh would you please to use git commit -sx to cherry-pick? Thanks

REF:

containerd/RELEASES.md

Line 180 in 8eea15f

process:

@bart0sh
Get CDI devices from CRI Config.CDIDevices field
6a5e54c 
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
(cherry picked from commit cd16b31)
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
@bart0sh bart0sh force-pushed the PR008-CDI-use-CRI-field-1.7 branch from 68f28c7 to 6a5e54c Compare May 16, 2023 15:50
@bart0sh
Copy link
Copy Markdown
Contributor Author

bart0sh commented May 16, 2023

@fuweid

would you please to use git commit -sx to cherry-pick? Thanks

Done

mikebrow
mikebrow approved these changes May 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fuweid
fuweid approved these changes May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 835383b into containerd:release/1.7 May 17, 2023
@dcantah dcantah mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikebrow mikebrow mikebrow approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

@AkihiroSuda AkihiroSuda

@mikebrow mikebrow

@fuweid fuweid

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bart0sh @k8s-ci-robot @fuweid @mikebrow @AkihiroSuda