Wire UpdatePodSandboxResources to Sandbox API#13118
Merged
Merged
Conversation
Provides test coverage for existing UpdatePodSandboxResources behavior. Assisted-by: Antigravity Signed-off-by: Chris Henzie <chrishenzie@gmail.com>
Integrates CRI container resource updates with core Sandbox API plugin. Delegates payload to out-of-tree controllers via UpdateSandbox API. Gracefully tolerates ErrNotImplemented to preserve backwards compatibility for legacy sandboxers. Assisted-by: Antigravity Signed-off-by: Chris Henzie <chrishenzie@gmail.com>
mxpv
approved these changes
Mar 25, 2026
samuelkarp
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridges the gap between the CRI
UpdatePodSandboxResourcesendpoint and out-of-tree Sandbox Controllers, addressing previous design feedback (e.g., from #11406).Adds a
UpdateSandboxinterface method on the CRIsandboxServicewrapper which routes updates to the sandbox controller. Includes unit test coverage for pre-existing CRI handler behavior + new behavior callingUpdateSandbox.Assisted-by: Antigravity