[release/1.7] test: added runc v1 tests using vagrant#11896
[release/1.7] test: added runc v1 tests using vagrant#11896dmcgowan merged 1 commit intocontainerd:release/1.7from
Conversation
|
Hi @Madraceee. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The same tests seems to be working fine after re-running them again. Is it possible to retrigger the failed cases? |
|
/ok-to-test |
|
/retest You can use |
.github/workflows/ci.yml
Outdated
| - name: test-cri | ||
| run: sudo BOX=$BOX vagrant up --provision-with=selinux,install-runc,install-gotestsum,test-cri | ||
|
|
||
| integration-vagrant-v1: |
There was a problem hiding this comment.
WDYT of adding it to the above integration-vagrant itself, using http://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#expanding-or-adding-matrix-configurations for io.containerd.runc.v1, io.containerd.runtime.v1.linux so we can test v1 shim only on almalinux/8
There was a problem hiding this comment.
Sure, I will make the change and update the PR.
Is there anything else you would like me to change? Or is the changes good?
|
Can you update the second commift for whitespace errors. ? Ref: https://github.com/containerd/containerd/actions/runs/15303471746/job/43049980393?pr=11896 |
|
How do I exactly fix this? |
|
@Madraceee, you can rebase on the base branch (i.e. While you have the hood open, it is probably fine to squash the commits as well. I don't think having seperate commits would bring much value in this case. |
Signed-off-by: Nitheesh Raaja R <raajanitheesh@gmail.com>
|
@austinvazquez , I have done the steps u mentioned and squashed it into a single commit. Since there is a difference between the remote and local, git wont allow me to push unless I use |
|
Oh yep, I should have mentioned that. A force push is required after amending any commits. |
f7911a7 to
60e7312
Compare
|
/retest |
|
The CI Fuzz failure is unrelated. Its now being hit across release/1.7 branch |
|
The Linux integration test was failing as well. So retriggered to make sure it works. |
|
@akhilerm hope this PR fulfills #11830 for release/1.7. I will start working on release/1.6. @austinvazquez Thanks for the git tricks!! |
austinvazquez
left a comment
There was a problem hiding this comment.
Thanks for pushing this through.
fix: #11830
Added jobs to ci.yml to test runc v1 using vagrant
ping @akhilerm