[release/1.7] Update runc binary to v1.2.5#11395
Conversation
|
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Looks like golangci-lint config is borked in this branch 😢 cc @austinvazquez in case you're near a computer to have a peek |
|
Maybe it needs an updated version, as it looks to be quite behind |
|
That's an odd error. My instinct is this is related to a golang-lint-action release over the past few days because release/1.7 and release/1.6 are using floating tag syntax in CI. i.e. containerd/.github/workflows/ci.yml Line 36 in 12f214a |
|
Hmm, possibly? I was looking at the version of the linter itself, but perhaps it's the action yes; containerd/.github/workflows/ci.yml Line 39 in 12f214a |
|
Made #11400 which should fix this on 1.7 branch. The issuse is because the latest golangci-lint action version ( The 1.6 branch doesn't have this issue because we're using a pretty old golangci-lint version which hasn't removed this deprecated field. |
|
@thaJeztah Rebasing this on latest release/1.7/HEAD should fix those CI lint errors. If we can't force the bot to do it, maybe we should just close this and file a new one with the same cherry-picked commit. |
This is the fifth patch release in the 1.2.z series of runc. It primarily fixes an issue caused by an upstream systemd bug. There was a regression in systemd v230 which made the way we define device rule restrictions require a systemctl daemon-reload for our transient units. This caused issues for workloads using NVIDIA GPUs. Workaround the upstream regression by re-arranging how the unit properties are defined. Dependency github.com/cyphar/filepath-securejoin is updated to v0.4.1, to allow projects that vendor runc to bump it as well. CI: fixed criu-dev compilation. Dependency golang.org/x/net is updated to 0.33.0. diff: opencontainers/runc@v1.2.4...v1.2.5 Signed-off-by: Austin Vazquez <macedonv@amazon.com>
4fd59b0 to
27c472a
Compare
|
Thanks for bringing this in; sorry, had a busy day 🙈 |
This is an automated cherry-pick of #11388
/assign thaJeztah