[release/1.7] Fix console TTY leak in runc shim#11250
Conversation
|
Skipping CI for Draft Pull Request. |
f2c651e to
dbb30d7
Compare
|
The tests are failing for runc v1, which does not seem to support sandbox/grouping since the service only holds a single init container. Probably we can skip this test case for runc v1 configs. containerd/runtime/v2/runc/v1/service.go Lines 89 to 103 in bcc810d |
dbb30d7 to
6335aeb
Compare
|
@henry118, I see good point. Let me try that. |
|
Hello! Just checking if this is still blocked / if there's any updates to share? |
Signed-off-by: Henry Wang <henwang@amazon.com> (cherry picked from commit aedb079) Signed-off-by: Austin Vazquez <macedonv@amazon.com>
6335aeb to
0d26a5a
Compare
Signed-off-by: Henry Wang <henwang@amazon.com> (cherry picked from commit 652e4d0) Signed-off-by: Austin Vazquez <macedonv@amazon.com>
0d26a5a to
c3e24e0
Compare
|
Sorry for the delay. Huge find by @henry118 the test was not skipping on runtime "io.containerd.runc.v1". Updated the test now. |
|
@austinvazquez: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dims I think this should get into our proposed 1.7 release, but seems we are having e2e test failures here (like on 1.6 as well); happy to help dig into what's going on, but not sure how to gauge whether these are flakes or a real issue we should solve before we do another 1.7.x point release. |
|
@estesp , @dims, FWIW it seems the ResourceMetrics feature test failure seems to be resolved by kubernetes/kubernetes#130053. Also the Node tests failure seems to be a side-effect of the node test suite failing; not a seperate test case IIUC? |
|
+1 to skip the flaky test in pull-containerd-node-e2e-1-7. let me do that now. |
Backports #11161 to release/1.7 branch
The cherry-pick for 652e4d0 is not clean as some of the test utility functions are slightly different in release/1.7 and I included a skip for runc shimv1 integration testing which does not support sandbox.