[release/1.7 backport] Fix retry logic and concurrency issue with http fallback#11032
Merged
estesp merged 3 commits intoNov 21, 2024
Merged
Conversation
When no port is specified, allow falling back from 443 to 80 when http is specified along with a TLS configuration. Signed-off-by: Derek McGowan <derek@mcg.dev> (cherry picked from commit 02b6c69) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Derek McGowan <derek@mcg.dev> (cherry picked from commit d23c4b8) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Race detector complains about concurrent access such as with Dispatch on push. Signed-off-by: Derek McGowan <derek@mcg.dev> (cherry picked from commit 38e2f00) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
|
Hi @vvoland. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
/ok-to-test |
dmcgowan
approved these changes
Nov 20, 2024
estesp
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow fallback across default ports
When no port is specified in host, allow falling back from 443 to 80 when http is specified along with a TLS configuration. This increases the cases when https can be preferred and fixes a case where fallback does not happen after a connection refused where previously Docker would have fallen back.
Adds a mutex to protect fallback host
Fixes an issue with race detector complaining about concurrent access such as with Dispatch on push.