Skip to content

[release/1.7] Update the container exit log to info level#11007

Merged
dmcgowan merged 1 commit into
containerd:release/1.7from
ningmingxiao:1.7.x
Nov 21, 2024
Merged

[release/1.7] Update the container exit log to info level#11007
dmcgowan merged 1 commit into
containerd:release/1.7from
ningmingxiao:1.7.x

Conversation

@ningmingxiao

@ningmingxiao ningmingxiao commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

cherry pick from main , if container is exited log exited event is necessary.

@k8s-ci-robot

k8s-ci-robot commented Nov 15, 2024

Copy link
Copy Markdown

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added the area/cri Container Runtime Interface (CRI) label Nov 15, 2024
@akhilerm akhilerm changed the title internal/cri: log ctr's exit event on info level [release/1.7] internal/cri: log ctr's exit event on info level Nov 19, 2024
@akhilerm

akhilerm commented Nov 19, 2024

Copy link
Copy Markdown
Member

Can you refer to the commit on the main branch while cherry-picking as mentioned in https://github.com/containerd/containerd/blob/main/RELEASES.md#backporting

@ningmingxiao

ningmingxiao commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Can you refer to the commit on the main branch while cherry-picking as mentioned in https://github.com/containerd/containerd/blob/main/RELEASES.md#backporting

done

@dmcgowan

dmcgowan commented Nov 20, 2024

Copy link
Copy Markdown
Member

Try git cherry-pick -xsS <commit>, the reference is not showing up

@ningmingxiao
add info of exited event
47ff8e2 
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
(cherry picked from commit 7bd4d34)
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
@dmcgowan dmcgowan merged commit 8170354 into containerd:release/1.7 Nov 21, 2024
@dmcgowan dmcgowan changed the title [release/1.7] internal/cri: log ctr's exit event on info level [release/1.7] Update the container exit log to info level Nov 21, 2024
@ningmingxiao ningmingxiao deleted the 1.7.x branch January 28, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@akhilerm akhilerm akhilerm approved these changes

Assignees

No one assigned

Labels

area/cri Container Runtime Interface (CRI) impact/changelog needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ningmingxiao @k8s-ci-robot @akhilerm @dmcgowan @samuelkarp