[release/1.7] Migrate log imports to github.com/containerd/log#10269
Merged
estesp merged 1 commit intocontainerd:release/1.7from May 28, 2024
Merged
[release/1.7] Migrate log imports to github.com/containerd/log#10269estesp merged 1 commit intocontainerd:release/1.7from
github.com/containerd/log#10269estesp merged 1 commit intocontainerd:release/1.7from
Conversation
e483bcc to
f5eeeeb
Compare
Member
Author
|
Looks like I wrote "logs" (plural) in the commit message; let me fix that to prevent confusion. |
Import the log module directly, instead of using the aliases that are provided in the log package. This helps find code-paths that still depend on the old location, and that haven't migrated yet to the new module. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
f5eeeeb to
0af6825
Compare
akhilerm
approved these changes
May 27, 2024
estesp
approved these changes
May 28, 2024
github.com/containerd/log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import the logs module directly, instead of using the aliases that are provided in the logs package. This helps find code-paths that still depend on the old location, and that haven't migrated yet to the new module.