Skip to content

Flag usage uses uppercase letters #8232

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
panguicai008:flag-usage
Mar 9, 2023
Merged

Flag usage uses uppercase letters #8232
dmcgowan merged 1 commit intocontainerd:mainfrom
panguicai008:flag-usage

Conversation

@panguicai008
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @panguicai008. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Iceber
Copy link
Copy Markdown
Member

Iceber commented Mar 8, 2023

There seems to be a lot of similar questions, could you update them together?

grep Usage ./cmd/ctr -r

Signed-off-by: panguicai008 <guicai.pan@daocloud.io>
@panguicai008
Copy link
Copy Markdown
Contributor Author

There seems to be a lot of similar questions, could you update them together?

grep Usage ./cmd/ctr -r

thanks. i have done

@k8s-ci-robot
Copy link
Copy Markdown

@panguicai008: GitHub didn't allow me to request PR reviews from the following users: Iceber.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Iceber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Iceber
Copy link
Copy Markdown
Member

Iceber commented Mar 8, 2023

Similar to #7976, it looks like #7976 has a lot of unchanged parts

@estesp
Copy link
Copy Markdown
Member

estesp commented Mar 8, 2023

I did a search of all usage strings and this matches the 83 I found that still were lowercase even after #7976. Thanks, LGTM

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Mar 8, 2023

Signed-off-by: panguicai008 <guicai.pan@daocloud.io>

Is this the name you prefer to use for signing off and to show up in the changelog?

@panguicai008
Copy link
Copy Markdown
Contributor Author

Signed-off-by: panguicai008 <guicai.pan@daocloud.io>

Is this the name you prefer to use for signing off and to show up in the changelog?

yes. thanks

@dmcgowan dmcgowan merged commit 0fe3b49 into containerd:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants