[release/1.7 backport] local: avoid writing to content root on readonly store#10913
Conversation
A contentstore can be created on top of readonly path and should not fail unless there is an attempt to write into it. Currently this fails because new ingest directory is created always, meaning for example that you can't create a store to read blobs from OCI layout without it contaminating the OCI layout files. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 3cc2343) Signed-off-by: Austin Vazquez <macedonv@amazon.com>
|
Hi @austinvazquez. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
looks like we're one approval short? /cc @tonistiigi or @dmcgowan |
A contentstore can be created on top of readonly path and should not fail unless there is an attempt to write into it.
Currently this fails because new ingest directory is created always, meaning for example that you can't create a store to read blobs from OCI layout without it contaminating the OCI layout files.
(cherry picked from commit 3cc2343)