Conversation
emcfarlane
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will push our users past CVE-2024-24786 and also mean that users don't have to think about whether the next release is affected by the CVE when they do
go install connectrpc.com/cmd/protoc-gen-connect-go@v1.16.0.However it does mean users may be confronted with the compatibility issue (which, luckily, is easily fixed by users also updating their dependency for
github.com/golang/protobuf).gRPC recently took this step, too. And since we're expecting another release soon (this week?), now seems like the right time.