fix: record actual link type in PrefixRecord#2169
Merged
baszalmstra merged 3 commits intoconda:mainfrom Mar 6, 2026
Merged
Conversation
baszalmstra
requested changes
Mar 5, 2026
Collaborator
baszalmstra
left a comment
There was a problem hiding this comment.
Maybe its nicer if this is just returned from link_package_sync instead? Instead of recomputing it?
Contributor
Author
Okaay looking into it now, and coming up with a fresh commit in a few. |
Contributor
Author
Pushed a new commit now @baszalmstra , does it look good now ? |
…dcoded HardLink Signed-off-by: RITANKAR SAHA <ritankar.saha786@gmail.com>
…recomputing Signed-off-by: RITANKAR SAHA <ritankar.saha786@gmail.com>
ad8a129 to
7a18b20
Compare
Contributor
Author
|
@baszalmstra can you take a look into this ? FIxed the reviews. |
baszalmstra
approved these changes
Mar 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the TODO in installer/mod.rs that noted link_type: Some(LinkType::HardLink) was always
hardcoded.
Problem
PrefixRecord.link.link_type was always written as HardLink, even when:
The actual file linking via link_package_sync was already correct (it probes filesystem capability
and falls back to copies). Only the metadata recording was wrong.
Solution
Fixes #2168
How Has This Been Tested?
Two new unit tests in installer::tests:
Checklist: