feat!: Make name in MatchSpec non-optional#2132
Merged
baszalmstra merged 4 commits intoconda:mainfrom Feb 28, 2026
Merged
Conversation
baszalmstra
requested changes
Feb 26, 2026
Collaborator
baszalmstra
left a comment
There was a problem hiding this comment.
Lets change the code to use as_exact and into_exact instead of Option::::From. I find that much more readable.
pavelzw
commented
Feb 26, 2026
Comment on lines
-596
to
-599
| let matching_package = records.iter().find(|record| match &constraint_spec.name { | ||
| Some(matcher) => matcher.matches(&record.as_ref().name), | ||
| None => false, | ||
| }); |
Member
Author
There was a problem hiding this comment.
this is a behavior change but makes more sense now. * should not match false but true every time
6 tasks
baszalmstra
approved these changes
Feb 28, 2026
Collaborator
|
thanks @pavelzw |
Merged
suhr25
added a commit
to suhr25/rattler
that referenced
this pull request
Mar 1, 2026
…name change After conda#2132 made MatchSpec::name non-optional (PackageNameMatcher instead of Option<PackageNameMatcher>), the dependency override lookup code still called .as_ref() which is not implemented for PackageNameMatcher. Replace with .as_exact() which returns Option<&PackageName> as intended. Also apply rustfmt formatting to PollResult::Validate struct literal in gcs_middleware.rs.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
xref #2079
Fixes #2039
How Has This Been Tested?
AI Disclosure
Tools: github pr review comments to unspecified model
Checklist: