Skip to content

add support for bind mount recursive#698

Merged
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:bind_recursive
Oct 15, 2024
Merged

add support for bind mount recursive#698
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:bind_recursive

Conversation

@ndeloof
Copy link
Copy Markdown
Collaborator

@ndeloof ndeloof commented Oct 15, 2024

@ndeloof ndeloof requested review from glours and jhrotko October 15, 2024 07:35
Comment on lines +422 to +423
"recursive": {"type": "string", "enum": ["z", "Z"]},
"selinux": {"type": "string", "enum": ["enabled", "disabled", "writable", "readonly"]}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inversion?

Suggested change
"recursive": {"type": "string", "enum": ["z", "Z"]},
"selinux": {"type": "string", "enum": ["enabled", "disabled", "writable", "readonly"]}
"selinux": {"type": "string", "enum": ["z", "Z"]},
"recursive": {"type": "string", "enum": ["enabled", "disabled", "writable", "readonly"]}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed. I'm trying to reduce my caffeine addiction, but this seems to come with side effects

Copy link
Copy Markdown
Collaborator

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Copy Markdown
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge (rebase) October 15, 2024 08:47
@glours glours merged commit 35c9659 into compose-spec:main Oct 15, 2024
@ndeloof ndeloof deleted the bind_recursive branch October 15, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants