Update compose-spec.json: remove invalid fields from array#684
Merged
glours merged 2 commits intocompose-spec:mainfrom Sep 24, 2024
Merged
Update compose-spec.json: remove invalid fields from array#684glours merged 2 commits intocompose-spec:mainfrom
glours merged 2 commits intocompose-spec:mainfrom
Conversation
Signed-off-by: Ana-Maria (A.) Manolache <ana-maria.manolache@ing.com>
ndeloof
approved these changes
Sep 24, 2024
ndeloof
requested changes
Sep 24, 2024
Collaborator
ndeloof
left a comment
There was a problem hiding this comment.
additionalProperties is indeed wrongly declared on watch type, while it should apply to the parent development element. Should not be removed but moved to parent type
glours
requested changes
Sep 24, 2024
Comment on lines
-504
to
-505
| "additionalProperties": false, | ||
| "patternProperties": {"^x-": {}} |
Collaborator
There was a problem hiding this comment.
Should be moved to the development level as this section is missing the capability to add extension attributes x-
Contributor
Author
There was a problem hiding this comment.
Added them back on development
…opment schema Signed-off-by: Ana-Maria (A.) Manolache <ana-maria.manolache@ing.com>
ndeloof
approved these changes
Sep 24, 2024
glours
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'additionalProperties' and 'patternProperties' are being declared for an array type, which is invalid. They are also declared for the items of the array, so they can be removed. Their presence is causing issues converting this jsonschema to its cuelang representation.
Fixes compose-spec/compose-spec#534