Skip to content

Revert "accept dashes in variable names"#680

Merged
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:revert_dash
Sep 9, 2024
Merged

Revert "accept dashes in variable names"#680
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:revert_dash

Conversation

@ndeloof
Copy link
Copy Markdown
Collaborator

@ndeloof ndeloof commented Sep 5, 2024

This reverts commit be170be.

we can't support dashes in variables as this conflict with the interpolation syntax for default values

closes #663

@ndeloof ndeloof requested review from glours and jhrotko September 5, 2024 08:39
@ndeloof ndeloof force-pushed the revert_dash branch 2 times, most recently from 7265431 to 0a7208e Compare September 5, 2024 14:31
Copy link
Copy Markdown
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This reverts commit be170be.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashes in variable names <=> environment: block

2 participants