Can't we just rely on https://pkg.go.dev/path/filepath#EvalSymlinks here ?

I also wonder we should do this for all path made absolute, not just watch where this had some side effect, wdyt?

Can't we just rely on https://pkg.go.dev/path/filepath#EvalSymlinks here ?

@ndeloof, the thing is, the directory is a symbolic link and not the file itself. I tried using EvalSymlinks but it was not enough for this case.

I also wonder we should do this for all path made absolute, not just watch where this had some side effect, wdyt?

I was not sure myself. I think the advantage of adding this change here, you do not need to deal with any transformations going further to compose to any watch code flow path. I can see both solutions working fine in this case

related : golang/go#42201
"No change in consensus, so declined."
Such a pleasure to see golang evolution