Merged
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
jhrotko
reviewed
Jun 27, 2024
| return err | ||
| } | ||
|
|
||
| return err |
Collaborator
|
that's a big change! (nice) did you try running compose e2e tests against this branch? |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Collaborator
Author
actually, I "just" extracted a long block into a new function. Github code review doesn't make this easy to notice tested on docker/compose#11950 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces
loadYamlFileto load a single compose file, running most of the processing.!resettags collected by a post-processor is returned to caller. It is used when running the recursive extends processing outside the main loading-and-merge pipelinefixes docker/compose#11937