Only ignore parsing errors when used with no-interpolate#613
Merged
ndeloof merged 1 commit intocompose-spec:mainfrom Apr 5, 2024
Merged
Only ignore parsing errors when used with no-interpolate#613ndeloof merged 1 commit intocompose-spec:mainfrom
ndeloof merged 1 commit intocompose-spec:mainfrom
Conversation
8f490e8 to
14de3f2
Compare
glours
approved these changes
Apr 3, 2024
transform/ports_test.go
Outdated
| tests := []struct { | ||
| name string | ||
| yaml any | ||
| want any |
Collaborator
There was a problem hiding this comment.
Why not add ignoreParseError bool here and a test to check we don't generate error when set to true?
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
14de3f2 to
5fcb219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing error must be ignored when interpolation is disabled so we don't try to parse
${PORT}as an IP address or port number, but when interpolation is enabled (loading intoProject) we must not ignore errors, otherwise the final error is a very generic onecloses docker/compose#11676