Skip to content

normalization creates implicit default network only when used by some service#595

Merged
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:normalizeNetworks
Apr 23, 2024
Merged

normalization creates implicit default network only when used by some service#595
glours merged 1 commit intocompose-spec:mainfrom
ndeloof:normalizeNetworks

Conversation

@ndeloof
Copy link
Copy Markdown
Collaborator

@ndeloof ndeloof commented Mar 12, 2024

default implicit network should not be introduced by normalization if not explicitly used by a service.

This let normalizeNetworks detect `default" network is used by some services and create this implicit network only if required

Copy link
Copy Markdown
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…me service

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours force-pushed the normalizeNetworks branch from 3f804fc to 8ff6e32 Compare April 23, 2024 08:03
@glours glours enabled auto-merge (rebase) April 23, 2024 08:03
@glours glours merged commit ced6565 into compose-spec:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants