Merged
Conversation
glours
approved these changes
Sep 20, 2023
Collaborator
glours
left a comment
There was a problem hiding this comment.
Ready to merge when the test will be fixed
d55a392 to
6e311e6
Compare
milas
approved these changes
Sep 20, 2023
milas
reviewed
Sep 20, 2023
|
|
||
| if s.Develop != nil { | ||
| for i, w := range s.Develop.Watch { | ||
| w.Path = absPath(workingDir, w.Path) |
Member
There was a problem hiding this comment.
Noting that this should fix the include + watch issue since we're now resolving the path at the right place.
My PR in #459 can still be useful for the future if/when we have other cases where we need to resolve paths outside of a load, but isn't critical anymore
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces support for
developsection as defined by compose-spec/compose-spec#253