Parse service device count to int if possible#442
Merged
ndeloof merged 1 commit intocompose-spec:masterfrom Aug 4, 2023
Merged
Parse service device count to int if possible#442ndeloof merged 1 commit intocompose-spec:masterfrom
ndeloof merged 1 commit intocompose-spec:masterfrom
Conversation
When set via an environment variable an integer will be represented by a string, resulting in an error. fixes: docker/compose#10667 Signed-off-by: Xiang Rong Lin <41164160+XiangRongLin@users.noreply.github.com>
dd5cd9b to
ecd8478
Compare
ndeloof
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When set via an environment variable an integer will be represented by a string, resulting in an error.
fixes: docker/compose#10667
The alternative would be to adjust the parsing of the yaml into the internal model, so it gets parsed as an int.
The env var is replaced in
compose-go/interpolation/interpolation.go
Line 74 in 95ac1be
But it only allows setting strings and not int
compose-go/interpolation/interpolation.go
Line 34 in 95ac1be