Skip to content

local environment to override included .env#449

Merged
ndeloof merged 1 commit intocompose-spec:masterfrom
ndeloof:env_override_include
Aug 25, 2023
Merged

local environment to override included .env#449
ndeloof merged 1 commit intocompose-spec:masterfrom
ndeloof:env_override_include

Conversation

@ndeloof
Copy link
Copy Markdown
Collaborator

@ndeloof ndeloof commented Aug 25, 2023

as we include another compose.yaml file and parse implicit or explicit sibling .env file, upper-level project environment should override values (just like FOO=BAR docker compose up does)

see docker/compose#10913

@ndeloof ndeloof requested review from laurazard and milas and removed request for laurazard August 25, 2023 12:59
Copy link
Copy Markdown
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Want to update TestLoadsWithInclude to cover this case? 😉

@ndeloof ndeloof force-pushed the env_override_include branch 3 times, most recently from 13ed0e3 to ff7381c Compare August 25, 2023 13:50
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof force-pushed the env_override_include branch from ff7381c to 15210d9 Compare August 25, 2023 14:05
@ndeloof ndeloof merged commit 1be5aca into compose-spec:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants