load: move env var profile detection to option#446
Merged
milas merged 1 commit intocompose-spec:masterfrom Aug 29, 2023
Merged
Conversation
Instead of reading `COMPOSE_PROFILES` environment variable directly during `load()`, rely exclusively on `opts.Profiles`. A new loader option, `WithDefaultProfiles`, allows passing profile name(s) via varargs. If none are provided, it will fallback to using any profiles set via `COMPOSE_PROFILES`. This improves purity of the loader and fixes issues with profiles being ignored for `include` (docker/compose#10906). Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Member
Author
|
Also, technically At the same time, one thing we've learned from |
Member
Author
Collaborator
|
@milas loader definitively should not use os.GetEnv |
ndeloof
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reading
COMPOSE_PROFILESenvironment variable directly duringload(), rely exclusively onopts.Profiles.A new loader option,
WithDefaultProfiles, allows passing profile name(s) via varargs. If none are provided, it will fallback to using any profiles set viaCOMPOSE_PROFILES.This improves purity of the loader and fixes issues with profiles being ignored for
include(docker/compose#10906).