fix(pebbledb): Initialize DB in batchDB constructor#128
Merged
jmalicevic merged 1 commit intomainfrom Jan 30, 2024
Merged
Conversation
melekes
approved these changes
Jan 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 76.74% 76.80% +0.05%
==========================================
Files 23 23
Lines 2043 2048 +5
==========================================
+ Hits 1568 1573 +5
Misses 403 403
Partials 72 72
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the comment, there is no specific need to initialize the DB for the batch version of pebble DB. But if we want to add functions like compaction, we need this to be initialized to something to avoid null pointer exceptions.