refactor: e2e-node docker build (backport #5176)#5178
Merged
mergify[bot] merged 2 commits intov0.38.xfrom Jun 5, 2025
Merged
Conversation
--- The way the old docker file worked, it would build images and tag them, but that tag gets overwritten by the multi-architecture build. This is very confusing because there is times during build where the multi-architecture build only has amd64 for a minute or so, then it only has arm64 for a minute or so, and assuming the job doesn't fail, it eventually becomes a true multi architecture image. This PR instead creates a separate tag for the single architecture build to make the intermediate steps a bit clearer, and in case of failure doesn't accidently leave a multi-arch build in a single-arch state. This can safely be backported to v1.x and v0.38.x #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit a7fd3a9) # Conflicts: # .github/workflows/testapp-docker.yml
Contributor
Author
|
Cherry-pick of a7fd3a9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Ironbird - launch a networkTo use Ironbird, you can use the following commands:
Custom Load Test ConfigurationYou can provide a custom load test configuration using the `--load-test-config=` flag:Use |
zrbecker
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the old docker file worked, it would build images and tag them, but that tag gets overwritten by the multi-architecture build.
This is very confusing because there is times during build where the multi-architecture build only has amd64 for a minute or so, then it only has arm64 for a minute or so, and assuming the job doesn't fail, it eventually becomes a true multi architecture image.
This PR instead creates a separate tag for the single architecture build to make the intermediate steps a bit clearer, and in case of failure doesn't accidently leave a multi-arch build in a single-arch state.
This can safely be backported to v1.x and v0.38.x
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #5176 done by [Mergify](https://mergify.com).