feat(proto): add SyncingToHeight to FinalizeBlockRequest#3134
Merged
Conversation
Syncing to FinalizeBlockRequestSyncingTo to FinalizeBlockRequest
SyncingTo to FinalizeBlockRequestSyncingTo height to FinalizeBlockRequest
SyncingTo height to FinalizeBlockRequestSyncingToHeight to FinalizeBlockRequest
andynog
approved these changes
May 28, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
looks good to me, minor suggestions/comments
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
sergio-mena
reviewed
May 29, 2024
sergio-mena
reviewed
May 29, 2024
sergio-mena
approved these changes
May 29, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks @melekes for implementing this! 🙏
This reverts commit 77cfcd2.
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2024
to let the ABCI app know if CometBFT is syncing or not. If the node is syncing/replaying blocks, the value is the maximum known height. If not, `SyncingToHeight` equals `Height` in `FinalizeBlockRequest`. Closes #1247 --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit 68e5e1b) # Conflicts: # api/cometbft/abci/v1/types.pb.go # internal/blocksync/reactor.go # state/execution.go
4 tasks
melekes
added a commit
that referenced
this pull request
May 30, 2024
…#3134) (#3146) to let the ABCI app know if CometBFT is syncing or not. If the node is syncing/replaying blocks, the value is the maximum known height. If not, `SyncingToHeight` equals `Height` in `FinalizeBlockRequest`. Closes #1247 --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3134 done by [Mergify](https://mergify.com). --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to let the ABCI app know if CometBFT is syncing or not. If the node is syncing/replaying blocks, the value is the maximum known height. If not,
SyncingToHeightequalsHeightinFinalizeBlockRequest.Closes #1247
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments