This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Merged
Conversation
7c4f481 to
abca9f7
Compare
We have setup a workflow for releasing codecov-cli. Currently it runs on every push to master. If you look at the releases page there are MANY releases being created as drafts. That polutes the visibility of true releases. Furthermore, the only asset we have being built works only on Linux distros, and we'd like to provide something for macos and windows users as well. We also have redundant CI jobs for PRs and master on push. To address all those concerns, first we are updating the CI workflows. `push_flow.yml` will run the lint-build-test steps for every push we have. This also uploades test coverage to codecov. `release_flow.yml` takes care of building new releases. It only runs when a new TAG is pushed, starting with `v` (for versions). To help us use the new release flow a new command is begin added to Makefile, the `tag.release` command. It should be used as `make tag.release version=v0.1.0`, for example. It takes care of tagging a new release and uploading it to GitHub, hopefully triggering the release_flow as well. The changes for `release_flow.yml` were inspired by [this tutorial](https://data-dive.com/multi-os-deployment-in-cloud-using-pyinstaller-and-github-actions/)
abca9f7 to
356c207
Compare
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 91.20% 91.32% +0.12%
==========================================
Files 59 60 +1
Lines 1831 1868 +37
==========================================
+ Hits 1670 1706 +36
- Misses 161 162 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dana-yaish
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have setup a workflow for releasing codecov-cli. Currently it runs on every push to master. If you look at the releases page there are MANY releases being created as drafts. That polutes the visibility of true releases. Furthermore, the only asset we have being built works only on Linux distros, and we'd like to provide something for macos and windows users as well.
We also have redundant CI jobs for PRs and master on push.
To address all those concerns, first we are updating the CI workflows.
push_flow.ymlwill run the lint-build-test steps for every push we have. This also uploades test coverage to codecov.release_flow.ymltakes care of building new releases. It only runs when a new TAG is pushed, starting withv(for versions).To help us use the new release flow a new command is begin added to Makefile, the
tag.releasecommand. It should be used asmake tag.release version=v0.1.0, for example. It takes care of tagging a new release and uploading it to GitHub, hopefully triggering the release_flow as well.The changes for
release_flow.ymlwere inspired by this tutorial