Merged
Conversation
5 tasks
murarustefaan
approved these changes
Apr 28, 2025
Member
murarustefaan
left a comment
There was a problem hiding this comment.
Good job on catching this!
erezrokah
approved these changes
Apr 28, 2025
przste-go
pushed a commit
that referenced
this pull request
Apr 28, 2025
#### Summary <!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> Following up on the transformer hanging issue reported by a customer and addressed in PR [#2130](#2130): Currently, the transformer plugin can increase the message size beyond the limit enforced in the sync method of plugin-sdk [1](https://github.com/cloudquery/plugin-sdk/blob/bc50fd3d2be414edba8f8ad5bb7739a012840bf1/internal/servers/plugin/v3/plugin.go#L267). To accommodate scenarios where transformers or destination plugins need to handle larger messages than the source plugin, we should consider increasing this limit to provide more flexibility. <!-- Explain what problem this PR addresses --> --- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅ --------- Co-authored-by: Bartosz Lesniewski <bartosz@cloudquery.io>
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
🤖 I have created a release *beep* *boop* --- ## [4.79.0](v4.78.0...v4.79.0) (2025-04-28) ### Features * Add transformer to update table description with its table options ([#2128](#2128)) ([2387b57](2387b57)) * Show plugin version in plugin server logs ([#2124](#2124)) ([be08606](be08606)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.10 ([#2132](#2132)) ([775d537](775d537)) * Prevent deadlock in transformer ([#2130](#2130)) ([a65b101](a65b101)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently sync method has 3 gorutines running in single errorGroup let's call them G1,G2 and G3
G1-
runs the transformer logic which consumes records from recvRecords and pushes them to sendRecords both of which are unbuffered channels. Gorutine g2 consumes record produced by G1
when gorutine g2 returns an error, code executing in G1 may hang indefinietly trying to write into channel that has no associated error.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)