fix: Don't call Tables gRPC method at the beginning of the sync#21180
Merged
kodiakhq[bot] merged 5 commits intomainfrom Jul 30, 2025
Merged
fix: Don't call Tables gRPC method at the beginning of the sync#21180kodiakhq[bot] merged 5 commits intomainfrom
kodiakhq[bot] merged 5 commits intomainfrom
Conversation
erezrokah
commented
Jul 30, 2025
| return err | ||
| } | ||
| // Pre init stats per table | ||
| for _, table := range sourceTables { |
Member
Author
There was a problem hiding this comment.
We don't really need the init code as Go Zero value gives us the same functionality
dcelasun
approved these changes
Jul 30, 2025
murarustefaan
approved these changes
Jul 30, 2025
stoovon
approved these changes
Jul 30, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
🤖 I have created a release *beep* *boop* --- ## [6.26.1](cli-v6.26.0...cli-v6.26.1) (2025-07-30) ### Bug Fixes * Don't call Tables gRPC method at the beginning of the sync ([#21180](#21180)) ([9510f5e](9510f5e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since this PR https://github.com/cloudquery/cloudquery/pull/20909/files the S3 source plugin fails to sync and result in the following error
failed to get tables: tables only discovered during sync.The reason is that the S3 source dynamically discovers all files/tables during the sync, and errors out if you call the tables endpoint before the sync is done, see https://github.com/cloudquery/cloudquery-private/blob/334760529da4815dc83659c7f529154682b2c8a0/plugins/source/s3/resources/plugin/client.go#L91
Instead of calling the tables endpoint we can keep track of the tables during the sync. This works even if you pass
--no-migratesince we skip those a bit after the new codecloudquery/cli/cmd/sync_v3.go
Line 600 in 7b59802