Use npm as fallback if no packageManager specified#190
Merged
Conversation
and no lockfile is present. Fixes #180
packageManager specifiedpackageManager specified
penalosa
approved these changes
Oct 10, 2023
Merged
This was referenced Oct 10, 2023
Merged
This was referenced Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180
#173 added a new
packageManagerinput to allow users to optionally specify which package manager they'd like to use when running the action. If the value isn't specified, it attempts to infer the appropriate package manager based on the presence of a lockfile. However, if no lockfile is found it throws an error. This was an inadvertent breaking change.Instead of throwing an error when the input isn't specified and no lockfile is found, we should now fallback to the previous behavior of using npm. Specifying an unsupported package manager, however, throws an error.
This PR also refactors the package manager logic and tests into its own module.