Support many package managers#166
Support many package managers#166JacobMGEvans merged 15 commits intocloudflare:mainfrom nix6839:many-package-manager
Conversation
|
My change will also allow the CI to run. |
|
This test in the branch I made to run CI (with my permissions for GH Auth Token) is showing the Environments E2E tests are failing now. https://github.com/cloudflare/wrangler-action/actions/runs/6225473338/job/16895989165 |
|
@JacobMGEvans Can you please allow CI again? I want to see error message. |
It is the error in the link in my comment. Its running CI in a separate branch because even if I approve this one it will fail since the GitHub Token requires a maintainer's PR to run. This is the link: https://github.com/cloudflare/wrangler-action/actions/runs/6225473338/job/16895989165 |
|
Is there anything I can do about it now? |
Figure out why your changes caused the Environment E2E's to fail, the action can be tested/developed locally with https://github.com/nektos/act If you don't I am sure someone will pick up the PR, if not me. |
|
@JacobMGEvans I fixed it. P.S. |
JacobMGEvans
left a comment
There was a problem hiding this comment.
I think this is a great initial implementation and covers some of the major package managers in the JS/TS ecosystem! Thanks for the hard work 😄
Change-type: patch See: cloudflare/wrangler-action#166
Change-type: patch See: cloudflare/wrangler-action#166
We must choose whether to install the package manager in this action or leave it up to the user.
Maybe fix #156