Require generated aliases to meet stricter naming requirements#9821
Merged
WillTaylorDev merged 1 commit intomainfrom Jul 3, 2025
Merged
Require generated aliases to meet stricter naming requirements#9821WillTaylorDev merged 1 commit intomainfrom
WillTaylorDev merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e4d3992 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
approved these changes
Jul 3, 2025
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Few minor nits. But otherwise LGTM
packages/wrangler/src/__tests__/versions/versions.upload.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/versions/versions.upload.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/versions/versions.upload.test.ts
Outdated
Show resolved
Hide resolved
0059437 to
4d76046
Compare
Test alias names with a regex to ensure it meets requirements prior to version upload. When we enable this for WCI we want to ensure that we aren't failing builds because the name is invalid.
4d76046 to
e4d3992
Compare
petebacondarwin
approved these changes
Jul 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce stricter validation for generated alias names
Add regex checks to ensure generated aliases conform to backend
requirements before uploading new versions. This will prevent unexpected
build failures when enabling in WCI, since alias names are auto-generated
and users might be unaware of invalid formats caused by branch naming.