CFSQL-1261: remove the need for d1 to patch wrangler for testing#9748
Merged
CFSQL-1261: remove the need for d1 to patch wrangler for testing#9748
Conversation
🦋 Changeset detectedLatest commit: 4a19ef3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
lambrospetrou
approved these changes
Jun 25, 2025
penalosa
approved these changes
Jun 25, 2025
penalosa
requested changes
Jun 25, 2025
Contributor
penalosa
left a comment
There was a problem hiding this comment.
Could you add a changeset? Even though it's an internal-only option
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
penalosa
approved these changes
Jun 30, 2025
061c6e0 to
422b919
Compare
422b919 to
4a19ef3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to CFSQL-1261
Describe your change...
On the D1 team, we are internally carrying a patch to add some fake location hints to create d1 databases in our internal staging environments.
When pairing with @penalosa , he thought that it would be better to make this into an environment variable so we don't have to carry a patch. This will make it easier to keep up with wrangler releases automatically in future.