Conversation
🦋 Changeset detectedLatest commit: d66c0b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
f4d3e3c to
d444918
Compare
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
1a8010e to
d1137ee
Compare
| const config = await runWranglerUntilConfig("dev"); | ||
| expect(config.dev.containerEngine).toEqual("test.sock"); | ||
| }); | ||
| it("should be able to be set by env var", async () => { |
There was a problem hiding this comment.
| it("should be able to be set by env var", async () => { | |
| it("should be able to be set by env var", async () => { |
| container_engine: "test.sock", | ||
| }, | ||
| }); | ||
| fs.writeFileSync("index.js", `export default {};`); |
There was a problem hiding this comment.
very nit 😅
| fs.writeFileSync("index.js", `export default {};`); | |
| fs.writeFileSync("index.js", "export default {};"); |
| writeWranglerConfig({ | ||
| main: "index.js", | ||
| }); | ||
| fs.writeFileSync("index.js", `export default {};`); |
There was a problem hiding this comment.
very nit 😅
| fs.writeFileSync("index.js", `export default {};`); | |
| fs.writeFileSync("index.js", "export default {};"); |
| port: 8888, | ||
| }, | ||
| }); | ||
| fs.writeFileSync("index.js", `export default {};`); |
There was a problem hiding this comment.
| fs.writeFileSync("index.js", `export default {};`); | |
| fs.writeFileSync("index.js", "export default {};"); |
|
so sorry it'll be really good to get this in the release so i'm gonna ignore your nits 🧡 🧡 🧡 feel free to make an issue and i'll clean up later |
this wasn't correctly being passed to miniflare - also added some tests.
This key is set under
devin the wrangler config because its not relevant to prod and only applies to local dev. We also haveenable_containersthat is set in the same place.