Skip to content

add experimental support for mixed mode in vitest-pool-workers#9473

Merged
dario-piotrowicz merged 6 commits intomainfrom
dario/DEVX-1856/mixed-mode-vitest
Jun 12, 2025
Merged

add experimental support for mixed mode in vitest-pool-workers#9473
dario-piotrowicz merged 6 commits intomainfrom
dario/DEVX-1856/mixed-mode-vitest

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Jun 4, 2025

Fixes https://jira.cfdata.org/browse/DEVX-1856

This PR adds support for mixed mode in vitest-pool-workers it also introduces a public utility to start or update mixed mode sessions.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: experimental feature change
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a wrangler v3 feature

@dario-piotrowicz dario-piotrowicz added e2e Run wrangler + vite-plugin e2e tests on a PR every-os labels Jun 4, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 4, 2025

🦋 Changeset detected

Latest commit: 756ed2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 4, 2025
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review June 4, 2025 14:41
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner June 4, 2025 14:41
@dario-piotrowicz dario-piotrowicz requested a review from a team June 4, 2025 14:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 4, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/DEVX-1856/mixed-mode-vitest might be a good starting point.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 4, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-wrangler-9473
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-workers-bindings-extension-9473 -O ./cloudflare-workers-bindings-extension.0.0.0-v5da3e1d3a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5da3e1d3a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-create-cloudflare-9473 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-kv-asset-handler-9473

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-miniflare-9473

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-pages-shared-9473

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-unenv-preset-9473

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-vite-plugin-9473

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-vitest-pool-workers-9473

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-workers-editor-shared-9473

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-workers-shared-9473

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471686408/npm-package-cloudflare-workflows-shared-9473

Note that these links will no longer work once the GitHub Actions artifact expires.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1856/mixed-mode-vitest branch from 570aecd to 3e7b61b Compare June 5, 2025 10:28
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1856/mixed-mode-vitest branch from 7c1da7f to 4d0a487 Compare June 5, 2025 15:48
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jun 5, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9473

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9473

miniflare

npm i https://pkg.pr.new/miniflare@9473

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9473

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9473

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9473

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9473

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9473

wrangler

npm i https://pkg.pr.new/wrangler@9473

commit: 756ed2e

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1856/mixed-mode-vitest branch from 58828f0 to 6b28627 Compare June 5, 2025 22:14
@dario-piotrowicz dario-piotrowicz requested a review from penalosa June 6, 2025 09:42
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1856/mixed-mode-vitest branch 2 times, most recently from b7f773a to daf6c39 Compare June 9, 2025 09:45
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1856/mixed-mode-vitest branch 2 times, most recently from 65339f7 to 270bb33 Compare June 11, 2025 15:00
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1856/mixed-mode-vitest branch from cf47802 to 7a81fb2 Compare June 11, 2025 17:42
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1856/mixed-mode-vitest branch from 7a81fb2 to 90bcd4e Compare June 11, 2025 18:19
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 12, 2025
@TavoElgueaLopez

This comment was marked as spam.

@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit fae8c02 Jun 12, 2025
28 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-1856/mixed-mode-vitest branch June 12, 2025 13:28
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants