add mixed-mode support to vite-plugin#9308
Merged
jamesopstad merged 6 commits intomainfrom May 28, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: aab3ee8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-wrangler-9308Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-workers-bindings-extension-9308 -O ./cloudflare-workers-bindings-extension.0.0.0-v6764c2058.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v6764c2058.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-create-cloudflare-9308 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-kv-asset-handler-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-miniflare-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-pages-shared-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-unenv-preset-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-vite-plugin-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-vitest-pool-workers-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-workers-editor-shared-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-workers-shared-9308
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15307359171/npm-package-cloudflare-workflows-shared-9308Note that these links will no longer work once the GitHub Actions artifact expires. |
82101f5 to
2301066
Compare
d35b44d to
dc8e24a
Compare
dc8e24a to
91f6732
Compare
penalosa
reviewed
May 28, 2025
remove extra mixedModeConnectionString check
simplify queues mapping
rename `resolveRemotesTo` to `mixedModeConnectionString`
avoid restarting mixed-mode sessions
penalosa
approved these changes
May 28, 2025
jamesopstad
approved these changes
May 28, 2025
Contributor
jamesopstad
left a comment
There was a problem hiding this comment.
Looks great! I don't love that this is coupling the Vite plugin more to Wrangler but it's fine for now. It would be good to discuss at some point if these utilities should live somewhere else.
jamesopstad
reviewed
May 28, 2025
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.cfdata.org/browse/DEVX-1855
This PR adds support to mixed-mode for the vite-plugin